This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[xdl] pass app.json updates config to expo-updates in standalone apps #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
reviewed
Aug 29, 2020
EvanBacon
reviewed
Aug 29, 2020
EvanBacon
reviewed
Aug 29, 2020
bbarthec
approved these changes
Aug 31, 2020
esamelson
force-pushed
the
@eric/updates-config-standalone
branch
from
3225546
to
62711af
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes expo/expo#9922, along with expo/expo#9985
This PR passes the
updates.checkAutomaticallyandupdates.fallbackToCacheTimeoutapp.json values, which were previously set at runtime, into build-time configuration values for standalone apps built by turtle. These values will then be read and passed directly to expo-updates by the ExpoKit kernels.Further, starting with SDK 39 the filenames that the ExpoKit kernel expects for the embedded manifest and bundle have changed, from
shell-app-manifest.jsonandshell-app.bundletoapp.manifestandapp.bundle. This PR makes that change accordingly for building standalone apps.