Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[expo-cli] Generate-module fixes and improvements #2548

Merged
merged 5 commits into from
Aug 31, 2020

Conversation

barthap
Copy link
Contributor

@barthap barthap commented Aug 31, 2020

Why

Continuation of #2510 (that fix was rather critical). Trying to make expo generate-module more universal and generic.

Changes

  • Android test files are now properly renamed
  • Java package is now automatically detected based on directory structure
  • NPM template package name accepts templates with tags @next and @latest (shall we make it less restrictive to accept any string as tag?)
  • Package names are now properly handled regardless of having expo- prefix.
  • iOS pod name always defaults to EXPackageName (it didn't always add EX prefix before) - idk if it's desirable change.
  • IO optimizations - parallelised some file processing.

Test plan

Tested manually using custom testing template (custom package names etc). Checked if all renamings work as expected.

@barthap barthap requested a review from bbarthec August 31, 2020 10:12
@barthap barthap marked this pull request as ready for review August 31, 2020 11:15
@barthap barthap merged commit 2a7b31e into master Aug 31, 2020
@barthap barthap deleted the @barthap/generate-module branch August 31, 2020 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants