This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[xdl] Switch to in-process Metro JS bundling starting from SDK 40 #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always use in-process Metro for SDK 40 and newer. For older SDK versions, keep the old behavior (in-process Metro can be enabled by setting `EXPO_USE_DEV_SERVER=true` in the environment).
3 tasks
EvanBacon
approved these changes
Nov 19, 2020
|
I just tried to run expo start with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use in-process Metro (
@expo/dev-server) for SDK 40 and newer. Metro is used to bundle JS inexpo start,expo publishandexpo exportcommands.@expo/dev-serveris a rewrite of the interface between Expo CLI and Metro bundler that uses the JS APIs of Metro (instead of running React Native CLI as a subprocess) to make bundling faster and handling Metro configurations more predictable.For older SDK versions, keep the old behavior (in-process Metro can be enabled by setting
EXPO_USE_DEV_SERVER=truein the environment).This is not a breaking change because the behavior for already released SDKs stays the same and all SDK 40 testing is done using in-process Metro.
Fixes #2322.