Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Expo 5.3.0 update #167

Closed
PatrickCleary opened this issue Mar 13, 2022 · 4 comments
Closed

Issue with Expo 5.3.0 update #167

PatrickCleary opened this issue Mar 13, 2022 · 4 comments

Comments

@PatrickCleary
Copy link

PatrickCleary commented Mar 13, 2022

Description of the bug

How would you shortly summarise the issue?
When expo upgraded to 5.3.0 my deployments began failing with:

Run expo/expo-github-action@v5
Installing Expo CLI (5.3.0) from cache or with npm
Error: Error: EACCES: permission denied, copyfile '/home/runner/work/_temp/_github_home/.aws/amplify/deployment-secrets.json' -> '/opt/hostedtoolcache/expo-cli/5.3.0/x64/_github_home/.aws/amplify/deployment-secrets.json'

I'm not sure if it is only an issue with AWS Amplify or not.

To Reproduce

What steps did you perform which led to this issue?

GitHub action configuration:

  - uses: expo/expo-github-action@v5
        with:
          expo-packager: npm
          expo-username: ${{ secrets.EXPO_CLI_USERNAME }}
          expo-password: ${{ secrets.EXPO_CLI_PASSWORD }}
          expo-cache: true

Expected behavior

What did you expect to have happened?
configure Expo within action

Actual behavior

What did it actually result in?
The error posted above

Additional context

Can you further explain the issue? E.g., information about version/environment or screenshots.
Updated my configuration to:

  - uses: expo/expo-github-action@v5
        with:
          expo-packager: npm
          **expo-version: 5.2.0**
          expo-username: ${{ secrets.EXPO_CLI_USERNAME }}
          expo-password: ${{ secrets.EXPO_CLI_PASSWORD }}
          expo-cache: true
      And my deployments began succeeding again.
@PatrickCleary
Copy link
Author

Not urgent or anything, the work around I have is fine. Just thought I would let the developers know. Sorry for lack of details.

byCedric added a commit that referenced this issue Mar 17, 2022
This should add more visibility if something is going wrong, like #167.
byCedric added a commit that referenced this issue Mar 17, 2022
* chore: update e2e tests to try npm and macos

This should add more visibility if something is going wrong, like #167.

* test: see if which properly resolves npm on windows

* test: try with execution

* test: try a couple of things including mkdirP and absolute toolpath

* chore: try to pass the name of the packager instead

* chore: remove the test code from the workflow
github-actions bot pushed a commit that referenced this issue Mar 17, 2022
### [7.1.1](7.1.0...7.1.1) (2022-03-17)

### Bug fixes

* package tool escape path on windows ([#169](#169)) ([db9b5ce](db9b5ce)), closes [#167](#167)

### Other chores

* add tags syncing to the release workflow ([eb1ffb8](eb1ffb8))
* fix dirty repo preventing tag bump ([7cde8f8](7cde8f8))

### Documentation changes

* add direct link to expo access tokens ([1f38d16](1f38d16))
* increase visibility of the EXPO_TOKEN link ([#168](#168)) ([9fce70f](9fce70f))
* **preview-comment:** update expo-cli version to latest ([4681fcf](4681fcf))
* reword the assumptions on package manager ([459b567](459b567))
@byCedric
Copy link
Member

byCedric commented Mar 17, 2022

Hi @PatrickCleary! I'm not exactly sure what's going on with the amplify stuff. I don't think we are calling amplify in any way, so it's probably a dependency to run the project (if it contains amplify). If your project is calling it, then I don't know why it's picking the Expo CLI's version of amplify.

That being said, the latest e2e tests for version v7 (or 7.1.1 exactly) shows that you can install expo-cli@5.3.0 without issues using either npm or yarn. So I would recommend upgrading your version to v7. Heads up, there are slightly different settings with the newer version:

expo/expo-github-action@v5

  - uses: expo/expo-github-action@v5
    with:
      expo-packager: npm
      expo-username: ${{ secrets.EXPO_CLI_USERNAME }}
      expo-password: ${{ secrets.EXPO_CLI_PASSWORD }}
      expo-cache: true

expo/expo-github-action@v7

  - uses: expo/expo-github-action@v7
    with:
      expo-version: latest
      packager: npm
      token: ${{ secrets.EXPO_TOKEN }}
  • expo-version has to be defined in order to install it, we also support eas-version in case you need eas-cli
  • expo-packager has been renamed to packager because this also applies to installing eas-cli
  • expo-cache is now set to true by default
  • expo-username|password has been deprecated since v6, and removed in v7, in favor of access tokens - you can create yours here.

Let me know if you run into issues when upgrading, or if something blocks you from doing so!

@PatrickCleary
Copy link
Author

Sorry, didn't see there was a new version. Thanks!

@byCedric
Copy link
Member

byCedric commented Mar 18, 2022

No worries! Github doesn't do a good job informing you about new changes. Lmk if you run into more trouble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants