Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview): filter slugs with special characters to match dev clients exp+<slug> scheme #252

Merged

Conversation

byCedric
Copy link
Member

Linked issue

Fixes #251

Additional context

Use the same filtering of slugs, as done in the expo-dev-client plugin here.

@byCedric byCedric changed the title test(preview): add tests for eas update qr code urls fix(preview): filter slugs with special characters to match dev clients exp+<slug> scheme Jan 15, 2024
@byCedric byCedric merged commit b8a9be8 into main Jan 15, 2024
14 checks passed
@byCedric byCedric deleted the @bycedric/preview/fix-qr-codes-with-special-char-in-slug branch January 15, 2024 12:28
expo-bot pushed a commit that referenced this pull request Jan 15, 2024
## [8.2.1](8.2.0...8.2.1) (2024-01-15)

### Bug fixes

* **preview:** filter slugs with special characters to match dev clients `exp+<slug>` scheme ([#252](#252)) ([b8a9be8](b8a9be8))
@expo-bot
Copy link

🎉 This PR is included in version 8.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev-client qr code scheme does not work for underscores in app slug
2 participants