Skip to content

Commit

Permalink
[menu-bar] Fix Window height on electron (#170)
Browse files Browse the repository at this point in the history
* [menu-bar] Fix Window height on electron

* Add changelog entry
  • Loading branch information
gabrieldonadel authored Feb 9, 2024
1 parent ec52e9d commit 2c55496
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
### 🎉 New features

- Add support for launching Expo updates. ([#134](https://github.com/expo/orbit/pull/134), [#137](https://github.com/expo/orbit/pull/137), [#138](https://github.com/expo/orbit/pull/138), [#144](https://github.com/expo/orbit/pull/144), [#148](https://github.com/expo/orbit/pull/148) by [@gabrieldonadel](https://github.com/gabrieldonadel))
- Add experimental support for Windows and Linux. ([#152](https://github.com/expo/orbit/pull/152), [#157](https://github.com/expo/orbit/pull/157), [#158](https://github.com/expo/orbit/pull/158), [#160](https://github.com/expo/orbit/pull/160), [#161](https://github.com/expo/orbit/pull/161), [#165](https://github.com/expo/orbit/pull/165) by [@gabrieldonadel](https://github.com/gabrieldonadel))
- Add experimental support for Windows and Linux. ([#152](https://github.com/expo/orbit/pull/152), [#157](https://github.com/expo/orbit/pull/157), [#158](https://github.com/expo/orbit/pull/158), [#160](https://github.com/expo/orbit/pull/160), [#161](https://github.com/expo/orbit/pull/161), [#165](https://github.com/expo/orbit/pull/165), [#170](https://github.com/expo/orbit/pull/170) by [@gabrieldonadel](https://github.com/gabrieldonadel))

### 🐛 Bug fixes

Expand Down
2 changes: 1 addition & 1 deletion apps/menu-bar/electron/modules/WindowManager/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const openWindow = async (moduleName: string, options: WindowOptions) => {

window = new BrowserWindow({
width: windowStyle.width ?? 300,
height: windowStyle.height ?? 400,
height: (windowStyle.height ?? 400) + (windowStyle.titlebarAppearsTransparent ? 30 : 0),
title: options?.title ?? moduleName,
frame: !windowStyle.mask?.includes(WindowStyleMask.FullSizeContentView),
resizable: windowStyle.mask?.includes(WindowStyleMask.Resizable) ?? false,
Expand Down

0 comments on commit 2c55496

Please sign in to comment.