Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar] Add electron support for AutoResizerRootView #157

Merged

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Jan 31, 2024

Why

Closes ENG-11331

How

  • Implement electron version of AutoResizerRootView using ResizeObserver
  • Update tsconfig to automatically include web types like window and ResizeObserver

Test Plan

Windows

image

macOS
image

@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-auto-resizer-root-view branch from 9945d03 to 2e8e5ef Compare January 31, 2024 19:58
Base automatically changed from @gabrieldonadel/electron to main January 31, 2024 23:16
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-auto-resizer-root-view branch from 2e8e5ef to 684b4cc Compare February 1, 2024 13:50
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-auto-resizer-root-view branch from 684b4cc to 0ea95d6 Compare February 2, 2024 13:52
Copy link

linear bot commented Feb 2, 2024

@gabrieldonadel gabrieldonadel marked this pull request as ready for review February 2, 2024 16:50
@gabrieldonadel gabrieldonadel merged commit 7b6e2b7 into main Feb 2, 2024
1 check passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/electron-auto-resizer-root-view branch February 2, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants