[menu-bar] Add Electron support for FilePicker #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
commented
Feb 9, 2024
| @@ -253,7 +253,7 @@ function Core(props: Props) { | |||
|
|
|||
| const installAppFromURI = useCallback( | |||
| async (appURI: string) => { | |||
| let localFilePath = appURI.startsWith('/') ? appURI : undefined; | |||
There was a problem hiding this comment.
Local file paths do not start with a slash in Windows
alanjhughes
approved these changes
Feb 9, 2024
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-file-picker
branch
from
2b14b3f
to
0a9cea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-11321
How
Use electron's
dialogAPI to add support for the FilePicker module when running electronTest Plan
Screen.Recording.2024-02-09.at.16.14.07.mov