✨ bring back query tests for node 21

[ctcpip]

@jonchurch

[wesleytodd]

These appveyor and coverage reports are intermittently broken so often now. Should we just remove then until we can land that other @jonchurch PR to migrate off it? Is it helpful if it is failing for no reason so often?

[ctcpip]

These appveyor and coverage reports are intermittently broken so often now. Should we just remove then until we can land that other @jonchurch PR to migrate off it? Is it helpful if it is failing for no reason so often?

If they're unreliable, perhaps at least remove them from the required status checks? Then they can still run but won't block merge. Although then commits/PRs might still not get the green check mark still, which is annoying.

[wesleytodd]

I would not be opposed to making that change, can we do that in code or is it only done in the config?

[wesleytodd]

I should have checked the setting before sending that. I just looked and do not see a setting to exclude an action run from the required checks. I also did a bit of searching and dont see a clear way to run a job but not make it required.

[ctcpip]

checks are configured to run via workflows. the requirement for them to merge PRs is done through repo settings / branch protection. behold:

[wesleytodd]

Ah, they are hidden! Thanks of for the tip, I just removed these from the branch protection rules. We should be able to merge in the UI without the override now.

[jonchurch]

Hmm, I merged this preemptively.

it looks like this still fails on latest 21, which is 21.7.3 currently.

it passes in our CI because we are using 21.6 @ctcpip

Simple enough though, we can skip it again the same way once we are testing against latest instead of pinned versions.

[ctcpip]

why do we pin the versions in CI?