Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure certain paths are always in gitignore #158

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

Anshuman-37
Copy link
Contributor

Fixes #148

Added /dist and extension.d.ts specifically as they were mentioned in the Issue

Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Anshuman-37, thanks for the PR!

Each template has its own .gitignore already. Can you pick one for reference and push a commit adding all its lines along with the lines you are adding? This way we streamline the process.

Also please add a console.log message to inform users about the operation, thought of something like:

export function writingGitIgnore() {
  return `🙈 - Writing ${brightYellow(`.gitignore`)} lines...`
}

Let me know if you need a hand btw, happy to assist

@jmg-duarte
Copy link

Each template has its own .gitignore already. Can you pick one for reference and push a commit adding all its lines along with the lines you are adding? This way we streamline the process.

Should the original gitignore's be deleted too?

Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great group work. Thanks @Anshuman-37 for the pull-request, @jmg-duarte for the review and @karlhorky for pivoting this update. Looking forward to the next collab!

Closes #148

@cezaraugusto cezaraugusto merged commit 39ad794 into extension-js:main Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dist and other ignores to .gitignore during create
3 participants