Add Pnpm support (follow-up of #162)

[cezaraugusto]

Follow-up PR of #162 after feedback reported in #162 (comment).

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
programs/develop/webpack/lib/utils.ts	60.00%	6 Missing ⚠️

Files with missing lines	Coverage Δ
programs/develop/webpack/lib/utils.ts	67.91% <60.00%> (+4.34%)	⬆️

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/extension-js/extension.js/extension@165

pnpm add https://pkg.pr.new/extension-js/extension.js/extension-develop@165

pnpm add https://pkg.pr.new/extension-js/extension.js/extension-create@165

commit: 9aaf238

[cezaraugusto]

@karlhorky can you please confirm if v2.0.0-alpha.18 works? that's what i run in the screenshot above

pnpx extension@2.0.0-alpha.18 create my-extension --template content-react

[karlhorky]

@cezaraugusto if you can, as I mentioned in problems 2 and 3 make sure to also try pnpm tsc (to run the TypeScript compiler), both before and after adding a usage of the chrome global in background.ts

[cezaraugusto]

@karlhorky thanks for figuring out the issues! I went over your comment and recorded a video with a working sample. When you get a chance please let me know if it works for you too!

pnpx extension@2.0.0-alpha.22 create my-extension --template=content-react

[karlhorky]

Nice!! Video looks mostly good, I noticed 2 things:

A) There was no testing of point 3 - using the chrome global in background.ts. here I added chrome.action.onClicked.addListener(() => {}) to background.ts and then ran pnpm tsc again, would be good to get that checked as well (maybe it's already working)
B) in the extension-env.d.ts, there are paths to ./node_modules/extension/... - I think you can use extension/... with those, without ./node_modules

[cezaraugusto]

@karlhorky sure! made a sample extension here https://github.com/cezaraugusto/sample-background-action-type. Below is the recording.

issue147-2.mp4

cc @OSpoon if you get a chance to review this one as well

[karlhorky]

@cezaraugusto great, thanks! Added a GitHub Actions CI workflow to run pnpm tsc here:

• Add GitHub Actions workflow for pnpm tsc cezaraugusto/sample-background-action-type#1

[cezaraugusto]

@karlhorky thanks for taking the time to follow up on this. the project has a lot of moving pieces, so it’s great to have your help. looking forward to your next contribution!

[karlhorky]

Thanks to you too! Great job 🙌