Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extension.js symnlink for local development #173

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

cezaraugusto
Copy link
Member

@cezaraugusto cezaraugusto commented Sep 6, 2024

This is a legacy code now. No template comes from "extension" installed by default (this is handled by the "create" command) so there is no need of symlinking the local node_module for development as there is no package to link.

fix #170

@cezaraugusto cezaraugusto self-assigned this Sep 6, 2024
Copy link

pkg-pr-new bot commented Sep 6, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/extension-js/extension.js/extension@173
pnpm add https://pkg.pr.new/extension-js/extension.js/extension-create@173
pnpm add https://pkg.pr.new/extension-js/extension.js/extension-develop@173

commit: e63c668

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Member

@OSpoon OSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great~

@cezaraugusto cezaraugusto merged commit b39cfe8 into main Sep 7, 2024
14 checks passed
@cezaraugusto cezaraugusto deleted the no-symlink-for-dev branch September 7, 2024 04:07
@cezaraugusto
Copy link
Member Author

Available in v2.0.0-alpha.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: spawn pnpm ENOENT
2 participants