Fix web_resources match patterns #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +65,7 @@ export class WebResourcesPlugin { | |||
| resources: resources.filter( | |||
| (resource) => !resource.endsWith('.map') | |||
| ), | |||
| matches | |||
| matches: cleanMatches(matches), | |||
There was a problem hiding this comment.
could you write a comment on top of this with the reasoning of why this is needed? this is for future reference.
if you're feeling adventurous, would love to have the first test for the feature-web-resources plugin. It's mainly creating a __spec__/clean-matches.spec.ts file with some edge cases. I'm using tests/comments as a reference to populate the new docs.
There was a problem hiding this comment.
Added a comment and some tests 👍
commit: |
cezaraugusto
approved these changes
Sep 14, 2024
|
Available in v2.0.0-alpha.28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177