Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move e2e tests to their own templates #184

Merged
merged 6 commits into from
Sep 15, 2024
Merged

Move e2e tests to their own templates #184

merged 6 commits into from
Sep 15, 2024

Conversation

cezaraugusto
Copy link
Member

It seems more scalable as we add more templates so we can just copy/paste a folder and adapt. It makes it easier to check which templates are not covered by e2e tests as well.

Also, I think in the future it will be great for users to create their extensions based on templates that include a test spec. Something like npx extension create my-extension --with-tests.

cc @OSpoon

@cezaraugusto cezaraugusto self-assigned this Sep 15, 2024
Copy link

pkg-pr-new bot commented Sep 15, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/extension-js/extension.js/extension@184
pnpm add https://pkg.pr.new/extension-js/extension.js/extension-create@184
pnpm add https://pkg.pr.new/extension-js/extension.js/extension-develop@184

commit: f1bdf2c

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@cezaraugusto cezaraugusto merged commit c72bd9c into main Sep 15, 2024
15 checks passed
@cezaraugusto cezaraugusto deleted the templates-e2e branch September 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant