Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show whitespace characters in diff #1147

Open
andresovela opened this issue Feb 24, 2022 · 5 comments
Open

Add option to show whitespace characters in diff #1147

andresovela opened this issue Feb 24, 2022 · 5 comments
Labels
dormant Marked by stale bot on close feature-request

Comments

@andresovela
Copy link

Is your feature request related to a problem? Please describe.
It would be nice to be able to see whitespace characters in the diff panel. Sometimes I see stuff like this:

Screenshot from 2022-02-24 10-40-04

My IDE displays the whitespace characters like this:

Screenshot from 2022-02-24 10-41-04

Describe the solution you'd like
An option to enable displaying whitespace characters.

Describe alternatives you've considered
Maybe highlighting the parts of the line that changed could help.

@stale stale bot added the dormant Marked by stale bot on close label Sep 28, 2022
@stale stale bot closed this as completed Oct 15, 2022
@extrawurst extrawurst reopened this Oct 18, 2022
Repository owner deleted a comment from stale bot Oct 18, 2022
@stale stale bot removed dormant Marked by stale bot on close labels Oct 18, 2022
@extrawurst
Copy link
Owner

this makes sense eventually but is not high on my priority list since I want/need to rewrite the whole diffing from scratch eventually to support external diff crates and not using the libgit2 internal one

@Kamilcuk
Copy link

@extrawurst Hi, truly an amazing project, and thank you for making it. I can click . for more options, type o for options, and then navigate to "Ignore whitespace" and change to true.

This works (!) thank you. But it only works for "Status [1]" view. But it does not work for "Log [2]" view after navigating to a commit.

I tried following https://github.com/extrawurst/gitui/blob/master/src/tabs/revlog.rs to find missing link of options. I see at

get_compare_commits_diff(&repo, (id, other), None, None)?
the options are not passed, but I do not know about the codebase.

@extrawurst extrawurst added bug Something isn't working good first issue Good for newcomers labels Apr 19, 2023
@extrawurst extrawurst modified the milestone: v0.23 Apr 19, 2023
@extrawurst extrawurst removed bug Something isn't working good first issue Good for newcomers labels Apr 19, 2023
@extrawurst
Copy link
Owner

I can click . for more options, type o for options, and then navigate to "Ignore whitespace" and change to true.

This works (!) thank you. But it only works for "Status [1]" view. But it does not work for "Log [2]" view after navigating to a commit.

good catch but an entirely different topic. please feel free to create another issue (maybe we have one for it already?)

@Kamilcuk
Copy link

Och, this issue is to show and not ignore the whitespaces. My bad, sorry.

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the dormant Marked by stale bot on close label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dormant Marked by stale bot on close feature-request
Projects
None yet
Development

No branches or pull requests

3 participants