Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore whitespace does not work in Log [2] view #1661

Closed
Kamilcuk opened this issue Apr 19, 2023 · 1 comment · Fixed by #1675
Closed

Ignore whitespace does not work in Log [2] view #1661

Kamilcuk opened this issue Apr 19, 2023 · 1 comment · Fixed by #1675
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@Kamilcuk
Copy link

Kamilcuk commented Apr 19, 2023

Describe the bug
Hi, truly an amazing project, and thank you for making it. I can click . for more options, type o for options, and then navigate to "Ignore whitespace" and change to true.

This works (!) thank you. But it only works for "Status [1]" view. But it does not work for "Log [2]" view after navigating to a commit.

To Reproduce
Steps to reproduce the behavior:

  1. click . for more options
  2. type o for options
  3. navigate to "Ignore whitespace"
  4. Change it to true
  5. click tab to open Log [2]
  6. choose commit with up/down arrows
  7. press enter
  8. choose file with up/down arrows
  9. when seeing file commit diff on the right whitespaces are still visible

Expected behavior
No whitespaces in dif.

Screenshots
image

Context (please complete the following information):

  • OS/Distro + Version: Fedora29
  • GitUI Version 0.22.1
  • Rust version: no rust on the machine

Additional context
I tried following https://github.com/extrawurst/gitui/blob/master/src/tabs/revlog.rs to find missing link of options. I see at

get_compare_commits_diff(&repo, (id, other), None, None)?
the options are not passed, but I do not know about the codebase.

I posted first on #1147 but then created new issue.

@Kamilcuk Kamilcuk added the bug Something isn't working label Apr 19, 2023
@extrawurst extrawurst added the good first issue Good for newcomers label Apr 21, 2023
@extrawurst extrawurst added this to the v0.23 milestone Apr 21, 2023
kamillo added a commit to kamillo/gitui that referenced this issue May 6, 2023
kamillo added a commit to kamillo/gitui that referenced this issue May 7, 2023


 * Pass SharedOptions to InspectCommitComponent and CompareCommitsComponent
kamillo added a commit to kamillo/gitui that referenced this issue May 7, 2023
…1661

 * Pass SharedOptions to InspectCommitComponent and CompareCommitsComponent
kamillo added a commit to kamillo/gitui that referenced this issue May 10, 2023
…1661

 * Pass SharedOptions to InspectCommitComponent and CompareCommitsComponent
@Kamilcuk
Copy link
Author

Thank you sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants