Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open commit editor doesn't show changes. #1420

Closed
vunhatchuong opened this issue Nov 6, 2022 · 2 comments
Closed

Open commit editor doesn't show changes. #1420

vunhatchuong opened this issue Nov 6, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone
v0.23

Comments

@vunhatchuong
Copy link

Describe the bug

When you write git commit it opens an editor with the list of changes to be commit, but GitUI doesn't show it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Staged Changes'
  2. Click on 'Commit'
  3. Click on 'Open Editor'
  4. See error

Expected behavior

Show list of changes to commit.

image

Actual behavior

Doesn't show list of changes.

image

Context (please complete the following information):

  • Pop!_OS + Version: [e.g. macOS 10.15.5]
  • GitUI Version 0.21
@vunhatchuong vunhatchuong added the bug Something isn't working label Nov 6, 2022
@extrawurst extrawurst added enhancement New feature or request and removed bug Something isn't working labels Nov 6, 2022
bc-universe added a commit to bc-universe/gitui that referenced this issue Nov 13, 2022
@bc-universe
Display commit changes (extrawurst#1420)
9baacf0 
When using an external editor to edit the commit message, the changes are now displayed
@bc-universe bc-universe mentioned this issue Nov 13, 2022
Closed
4 tasks
@extrawurst extrawurst added this to the v0.23 milestone Nov 23, 2022
extrawurst pushed a commit that referenced this issue Nov 23, 2022
@bc-universe @extrawurst
Display commit changes (#1420)
9b46bb6 
When using an external editor to edit the commit message, the changes are now displayed
@extrawurst
Copy link
Owner

fixed via 9b46bb6

extrawurst added a commit that referenced this issue Nov 23, 2022
@extrawurst
follow up to 9b46bb6 (see #1420)
ca19d42 
add standard "Changs to be commited" text on top of changes.
@extrawurst
Copy link
Owner

followup in ca19d42:
Screenshot 2022-11-23 at 15 30 25

IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
@bc-universe @IndianBoy42
Display commit changes (extrawurst#1420)
17bbe54 
When using an external editor to edit the commit message, the changes are now displayed
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
@extrawurst @IndianBoy42
follow up to 9b46bb6 (see extrawurst#1420)
4adfdbb 
add standard "Changs to be commited" text on top of changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.23
Development

Successfully merging a pull request may close this issue.

Display commit changes on external editor #1420 bc-universe/gitui
2 participants
@extrawurst @vunhatchuong