Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lag issue when showing files tab ( Files [3] ) with 0.22.1 #1451

Closed
MartinVincent opened this issue Nov 24, 2022 · 3 comments
Closed

lag issue when showing files tab ( Files [3] ) with 0.22.1 #1451

MartinVincent opened this issue Nov 24, 2022 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@MartinVincent
Copy link

Describe the bug
When upgrading from 0.22.0 to 0.22.1, I noticed a lag when showing files tab (Files [3]), which was absent in 0.22.0.

To Reproduce

  1. Setup env:
~/Code ❯ git clone https://github.com/extrawurst/gitui.git

Cloning into 'gitui'...
cd gitui
 ~/Code ❯ cd gitui/
 [master:ca19d42  ] ~/Code/gitui ❯ gitui_0.22.1 --version
gitui 0.22.1
  1. Run gitui
  2. Naviagte to tab 3: Files[3]
    • wait ~N seconds for files to show

Expected behavior
Expected the same behaviour as what was present in past versions: quasi instantaneous display of the files.

Screenshots
asciinema film/capture showing the difference between 0.22.0 and 0.22.1:
asciicast

Context (please complete the following information):

  • Ubuntu 20.04.02 LTS
  • GitUI Version 0.22.1
  • cargo 1.60.0 (d1fd9fe 2022-03-01)
@MartinVincent MartinVincent added the bug Something isn't working label Nov 24, 2022
@extrawurst
Copy link
Owner

Please compare again via switching to the tab after the app start. In your comparison the app start mode hide the lag in 0.22.0.

because this is exactly what I addressed in 8e8c5fa

@MartinVincent
Copy link
Author

Hum, problem persists AFAICT:

asciicast

@extrawurst extrawurst added this to the v0.23 milestone Nov 25, 2022
@extrawurst
Copy link
Owner

fixed. I forgot the debug code in there :(

IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants