Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

focus_right key binding doesn't work to inspect stash (right arrow still used) #1454

Closed
dblume opened this issue Nov 27, 2022 · 1 comment
Closed
Labels
bug Something isn't working
Milestone

Comments

@dblume
Copy link

dblume commented Nov 27, 2022

Describe the bug

If using the vim key bindings mentioned at KEY_CONFIG.md, the "l" key will focus right and move right as expected in most tabs but "Stashes". Tip at the bottom will say, "Inspect [l]" but you have to press the right arrow to inspect.

To Reproduce
Steps to reproduce the behavior:

  1. Use the vim key bindings mentioned at KEY_CONFIG.md. (Only focus_right matters for this bug.)
  2. Stash a change. (So you have something to see at step 4.)
  3. Run gitui, notice hjkl navigation works as expected.
  4. Go to Stashes Tab. Try to inspect the stash with the "l" key as described in the tip at the bottom of the screen. It doesn't work. But pressing the right-arrow key works, as if you hadn't installed any key bindings.

Expected behavior
Pressing the "l" key when focus is on a stash "inspects" the stash. (As the tip at the bottom suggests.)

Context (please complete the following information):

  • Windows WSL2 Ubuntu 20.04.1 LTS (and Ubuntu 20.04.5 LTS (not WSL))
  • GitUI Version 0.22.1
@dblume dblume added the bug Something isn't working label Nov 27, 2022
@extrawurst
Copy link
Owner

extrawurst commented Nov 28, 2022

inspecting the stash entry is actually a separate item in the bindings, please see stash_open at https://github.com/extrawurst/gitui/blob/master/vim_style_key_config.ron#L46

the bug here is that the label shown on the bottom does not use the right key binding 🤦‍♂️

@extrawurst extrawurst added this to the v0.23 milestone Nov 28, 2022
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants