Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better scrolling in diff/log #52

Closed
extrawurst opened this issue May 13, 2020 · 2 comments
Closed

better scrolling in diff/log #52

extrawurst opened this issue May 13, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@extrawurst
Copy link
Owner

now that the diff and log component know their render height, we can make scrolling/selecting more natural by only scrolling once the selection would leave the view instead of always centering the view over the selection.

@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers labels May 13, 2020
@stoope stoope mentioned this issue May 17, 2020
@extrawurst
Copy link
Owner Author

A little more clarification:
when the selection for would leave the view on the bottom (of log or diff) the view should scroll down one line to keep it in view. similar to the behaviour people know from tools like less and vim.

extrawurst pushed a commit that referenced this issue May 19, 2020
@extrawurst
Copy link
Owner Author

Picture says more than a thousand words, the new behaviour is implemented in log view now as an example:
Screenflick Movie 17

@extrawurst extrawurst added this to the 0.6.0 milestone Jun 1, 2020
@extrawurst extrawurst modified the milestones: 0.6.0, 0.7 Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant