Support using gitui with yadm #752
Comments
|
Probably related to #100 (comment) |
|
@IndianBoy42 gitui does not support bare repos and exits right away when you try to open it in one. so I am wondering why it even hangs for you. it should print out: please run |
|
It does open if i use `gitui -d path/to/repo.git`
I will generate a log file for your once I get home
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Stephan Dilly ***@***.***>
Sent: Sunday, May 30, 2021 4:04:57 PM
To: extrawurst/gitui ***@***.***>
Cc: Anshuman MEDHI ***@***.***>; Mention ***@***.***>
Subject: Re: [extrawurst/gitui] Support using gitui with yadm (#752)
@IndianBoy42<https://github.com/IndianBoy42> gitui does not support bare repos and exits right away when you try to open it in one. so I am wondering why it even hangs for you. it should print out:
invalid git path
please run gitui inside of a valid git (non-bare) repository
please run gitui again with the -l option to create logging into a log file and share the content
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#752 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABNUNQMRYJBHNKKD6NGYTLTTQHWSTANCNFSM45Y7OPIQ>.
|
|
from running that path is the location of all the git information for the git repository created by yadm |
the log does not indicate any problem |
|
Well gitui isn't crashing or anything, it just freezes on startup trying to find all untracked files (which for repositories like this shouldn't even be shown)
I've discovered if i wait 30 seconds it completes and shows all untracked files, and then briefly freezes every few seconds (updating status?)
I just think it would be a good idea to check the git config variables about whether untracked files should be visible
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Stephan Dilly ***@***.***>
Sent: Monday, May 31, 2021 1:56:14 AM
To: extrawurst/gitui ***@***.***>
Cc: Anshuman MEDHI ***@***.***>; Mention ***@***.***>
Subject: Re: [extrawurst/gitui] Support using gitui with yadm (#752)
https://pastebin.com/90pjLcTF
from running gitui -d ~/.config/yadm/repo.git -l
that path is the location of all the git information for the git repository created by yadm
the log does not indicate any problem
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#752 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABNUNQNP5CL3273FOOGQYE3TQJ335ANCNFSM45Y7OPIQ>.
|
I can cook up a test in a branch, can you build from source to test this then? |
|
I'd be glad to. I'm in a different time zone so I'm going to sleep, I can work on this tomorrow
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Stephan Dilly ***@***.***>
Sent: Monday, May 31, 2021 2:08:04 AM
To: extrawurst/gitui ***@***.***>
Cc: Anshuman MEDHI ***@***.***>; Mention ***@***.***>
Subject: Re: [extrawurst/gitui] Support using gitui with yadm (#752)
Well gitui isn't crashing or anything, it just freezes on startup trying to find all untracked files (which for repositories like this shouldn't even be shown) I've discovered if i wait 30 seconds it completes and shows all untracked files, and then briefly freezes every few seconds (updating status?) I just think it would be a good idea to check the git config variables about whether untracked files should be visible Get Outlook for Androidhttps://aka.ms/AAb9ysg
…
I can cook up a test in a branch, can you build from source to test this then?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#752 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABNUNQI6CXS2LQYOPQLMP3LTQJ5IJANCNFSM45Y7OPIQ>.
|
just pushed to also reference: https://git-scm.com/docs/git-config#Documentation/git-config.txt-statusshowUntrackedFiles |
|
The hardcoded hiding of untracked works, the files are not shown and startup is snappy again. I added a similar change in the Stashing tab For my own use, I have added code in my fork that checks the git config flags I mentioned before, as well as adding a --hide-untracked flag on the cli. I don't know if it fits your coding style, there weren't any CLI flags that had to be passed down to the widgets before, we may want to pass these flags around as a single object, but for now I just added boolean flags where necessary https://github.com/IndianBoy42/gitui/tree/status-without-untracked |
|
@IndianBoy42 please give #753 a go to verify that all works as expected then we can merge this into master |
Is your feature request related to a problem? Please describe.
This is half a feature request and half a bug.
I use YADM for managing my dotfiles, which essentially creates a bare git repo in the $HOME directory.
YADM adds a configuration option so when I do
yadm statusit doesnt try show all the untracked files.https://git-scm.com/docs/git-status#Documentation/git-status.txt---untracked-filesltmodegt
On the other hand when I try to use gitui (using
gitui -d ~/.config/yadm/repo.git),it gets stuck 'forever' probably trying to find/enumerate all the untracked files.
(Sublime Merge also seems to have this problem, but for example verco doesn't)
I suspect similar problems would happen in large repositories with large amounts of changed/untracked files
Describe the solution you'd like
I see a few ways this could be fixed
no-untrackedflag to do something similar to abovegui.displayuntrackedwhich is more directly related to GUIs and untracked files, it would be a good idea to look at this option tooDescribe alternatives you've considered
Unfortunately gitui is not really usable with YADM
The text was updated successfully, but these errors were encountered: