Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] more commands support #83

Closed
extrawurst opened this issue May 21, 2020 · 6 comments
Closed

[RFC] more commands support #83

extrawurst opened this issue May 21, 2020 · 6 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@extrawurst
Copy link
Owner

One of the main goals of gitui is to not require the user to learn cryptic hotkeys/shortcuts to work with it. The command bar (at the bottom) always shows what actions are available in the current context.

That said:
Right now, in certain views the command bar is already quiet full and especially crowded when using a small/narrow terminal.

some features right now are not tackled because of this:

one solution for this could be to automatically cut of the commands at the end and show a more [m] command that would popup something similar to the help but only with the available commands plus allowing to trigger them when pressing enter on one.

Any better ideas?

@extrawurst extrawurst added enhancement New feature or request question Further information is requested labels May 21, 2020
@jugglerchris
Copy link

Rather than listing the commands in full on the command bar, I think it would be fine to just list the keys and rely on the help popup if needed. So instead of:

Focus Stage [2] Stage Item [enter] Reset Item [D] Nav [←↑→↓] Diff [→] Help [h] Quit [ctrl+c] 

It could be:

[2][enter][D][←↑→↓][^c] Help [h]

or something along those lines, maybe grouping the single-character ones together.

@MCord
Copy link
Contributor

MCord commented May 21, 2020

we can use colors to compress commands a bit like Norton back in the day:

image

what about using sub-menus ? I mean for the less frequently commands instead of running the command we can open a submenu like:

image

This has the benefit of being self documenting and provides shortcut sequences for power users.

wdyt ?

@extrawurst
Copy link
Owner Author

So I gave this a bit more thought. The submenu approach has one drawback: We need a shortcut for every submenu to open to inspect the commands inside, or we need a shortcut that switches focus entirely to the menu structure and then use the arrow-keys to navigate the menu structure.
Both solutions do not feel right.

My idea right now is to keep the bottom-bar as is and cut of commands that do not fit the width. this would automatically add a more [space] shortcut at the end to expand the bottom bar to the required height to be able to draw all available commands.

image

commands already are sorted based on some sort of priority which should allow us to put the most important ones up front.

comments?

@MCord
Copy link
Contributor

MCord commented May 23, 2020

the problem with having a flat command toolbar is that it gets crowded fast and there is no grouping of related commands. on the other hand this design's is more horizontal which is an added value on modern screens.

@ciaranmooney
Copy link

I feel you may have painted yourself into a corner with your first two statements.

  1. One of the main goals of gitui is to not require the user to learn cryptic hotkeys/shortcuts to work with it.
  2. The command bar (at the bottom) always shows what actions are available in the current context.

The first is admirable however I believe the second is the root of the issue you are currently experiencing with the design.

It may be possible to add a third (implied) ambition which is also in conflict with the second above.

  1. Add more features users find beneficial.

There is limited screen real-estate available and whatever scheme you decide on now (eg, jugglerchris's reasonable suggestion above) will probably eventually hit the same problem as more features/combinations are introduced.

May I suggest re-phrasing your second statement to something more like:

  • It should always be easy to determine the correct command.

I would hope that this alternative statement opens up the "idea" space.

My suggestions would be:

  • a scheme where the first letter, or high lighted letter is the associated command key.
  • an easily accessible hint system where a key can be pressed to highlight the command. Such as pressing alt when using some GUIs where the shortcut key gains an underline.
  • a comprehesive, well laid out help modal.
  • a list of the most unused shortcuts at the bottom. The assumption being the user knows the most used because they are using them!

@extrawurst
Copy link
Owner Author

#101 contains a WIP of my suggested solution (#83 (comment)):
Screenflick Movie 23

After this I am considering adding another option to reduce the commands to the shortcuts-only like @jugglerchris suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants