Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic / core dump when viewing details on shallow commits #836

Closed
jabra11 opened this issue Aug 11, 2021 · 3 comments · Fixed by #837
Closed

panic / core dump when viewing details on shallow commits #836

jabra11 opened this issue Aug 11, 2021 · 3 comments · Fixed by #837
Labels
bug Something isn't working

Comments

@jabra11
Copy link

jabra11 commented Aug 11, 2021

Describe the bug

panic: Any { .. }
trace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: start_thread
   7: __GI___clone

Aborted (core dumped)

To Reproduce
git clone --depth 1 https://github.com/extrawurst/gitui (note the --depth 1 flag)
./gitui -> go to the log tab -> press enter to view details on the shallow commit

Expected behavior
Show details of the commit

Context (please complete the following information):
OS: Arch Linux
Kernel: x86_64 Linux 5.13.9-arch1-1
GitUI Version: 0.16.2
Rust version: rustc 1.54.0

Additional context
https://git-scm.com/docs/shallow

Useful, for example, when cloning plugins for vim (since only the last commit is fetched, it's faster that way)

@extrawurst extrawurst added the bug Something isn't working label Aug 11, 2021
@extrawurst
Copy link
Owner

the actual error:

[ERROR] panic: PanicInfo { payload: Any { .. }, message: Some(failed to fetch: Git(Error { code: -3, klass: 9, message: "object not found - no match for id (d6f43f063eedf95e33d019f41265e1d377a572ec)" })), location: Location { f
ile: "asyncgit/src/commit_files.rs", line: 72, col: 18 } }

@jabra11
Copy link
Author

jabra11 commented Aug 11, 2021

the actual error:

[ERROR] panic: PanicInfo { payload: Any { .. }, message: Some(failed to fetch: Git(Error { code: -3, klass: 9, message: "object not found - no match for id (d6f43f063eedf95e33d019f41265e1d377a572ec)" })), location: Location { f
ile: "asyncgit/src/commit_files.rs", line: 72, col: 18 } }

Is this only shown in debug builds?

@extrawurst
Copy link
Owner

the actual error:

[ERROR] panic: PanicInfo { payload: Any { .. }, message: Some(failed to fetch: Git(Error { code: -3, klass: 9, message: "object not found - no match for id (d6f43f063eedf95e33d019f41265e1d377a572ec)" })), location: Location { f
ile: "asyncgit/src/commit_files.rs", line: 72, col: 18 } }

Is this only shown in debug builds?

Nope it’s only logged if you use the respective argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants