Add stage_item/unstage_item to its own key_config

[merikan]

Is your feature request related to a problem? Please describe.
It's not a problem but would be an improvement to avoid misunderstandings

Describe the solution you'd like
I wanted to remap the stage_item/unstage_item to Spacebar instead of Enter, so I changed

enter: ( code: Enter, modifiers: ( bits: 0,),),    

to

enter: ( code: Char(' '), modifiers: ( bits: 0,),),

and it works great.

I have now changed the Enter key to Space but I do not know if it affects any other function that also uses the Enter keybinding.

It would be awesome if we had separate key-bindings for stage_item and unstage_item and they can of course be linked to Enter by default.

Describe alternatives you've considered
I have looked around in the code and can see that Enter is used in several places, so there are probably more places for improvements.

For me, Space is great to toggle on/off, and Enter is a great fit for confirming an operation, but that's just my personal preference. 😉

Thx for an awesome project 👍

[extrawurst]

That makes sense 👍

[alessandroasm]

I would like to work on that 🙂

[alessandroasm]

I've opened a PR to implement this feature. Please let me know if it needs adjustments.

[extrawurst]

@alessandroasm thanks for approaching this. now that I look into it I am wondering if we have any practical reason to separate staging/unstaging into separate keys? we only ever have one fo the two options anyway so my proposal would be to have one new stage_unstage_item key.

@merikan your thoughts?

[alessandroasm]

I forgot to update the Help.

I'll update the PR shortly.

[extrawurst]

@merikan next question: this new key should probably also apply instead of enter for staging hunks, right?

[merikan]

@extrawurst
Yes, I think the same key to toggle on/off is most intuitive and is usually how it works in other applications. It can of course be two different fields bound to the same keyboard-key i.e. SPACE
Yes, same key for staging hunks 👍