Default to tick-based updates #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reintroduces code that was previously removed in favor of a notify-based update trigger. It turned out that notify-based updates can cause issues in larger repositories, so tick-based updates seemed like a safer default. extrawurst#1444 extrawurst#1310
extrawurst
reviewed
Apr 19, 2023
src/args.rs
Outdated
| @@ -15,6 +15,7 @@ use std::{ | |||
| pub struct CliArgs { | |||
| pub theme: PathBuf, | |||
| pub repo_path: RepoPath, | |||
| pub notify_watcher: bool, | |||
| pub poll_watcher: bool, | |||
There was a problem hiding this comment.
poll_watcher should be deprecated by this, right? because it is the default
There was a problem hiding this comment.
what if we remove it? and people still call it?
There was a problem hiding this comment.
I followed your suggestion below and removed poll_watcher.
After the removal, clap prints an error when --poll is passed as an argument: error: unexpected argument '--poll' found.
src/main.rs
Outdated
| #[derive(Clone, Copy, PartialEq)] | ||
| enum Updater { | ||
| Ticker, | ||
| PollWatcher, |
There was a problem hiding this comment.
I would sunset the notify based poll watcher entirely or do you see any point in keeping it?
There was a problem hiding this comment.
No, if it’s causing issues that are not fixable or unlikely to be fixed, it makes more sense to completely remove it.
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this pull request
Jun 4, 2024
* Default to tick-based updates This commit reintroduces code that was previously removed in favor of a notify-based update trigger. It turned out that notify-based updates can cause issues in larger repositories, so tick-based updates seemed like a safer default. extrawurst#1444 extrawurst#1310 * Add FAQ entry for --watcher * Remove --poll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #1444.
It changes the following:
PR that introduced the notify-based watcher: #1310
I followed the checklist:
make checkwithout errors