Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to bwrap #1792

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Switch to bwrap #1792

merged 6 commits into from
Aug 9, 2023

Conversation

TheBlackSheep3
Copy link
Contributor

@TheBlackSheep3 TheBlackSheep3 commented Aug 5, 2023

This Pull Request fixes/closes #1762.

It changes the following:

  • removed dependency textwrap
  • added dependency bwrap

I followed the checklist:

  • I extended unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

prevent panic by overwriting with width 1 and added test case
@TheBlackSheep3 TheBlackSheep3 changed the title swap to bwrap Switch to bwrap Aug 5, 2023
@TheBlackSheep3 TheBlackSheep3 mentioned this pull request Aug 5, 2023
4 tasks
@TheBlackSheep3
Copy link
Contributor Author

@AmmarAbouZor i thought it was easier to just approach it again from scratch. Now the macro bwrap::wrap! is used.

@AmmarAbouZor
Copy link
Contributor

It looks simple and elegant now 💯

@extrawurst extrawurst merged commit 403c5aa into extrawurst:master Aug 9, 2023
19 checks passed
@extrawurst
Copy link
Owner

@TheBlackSheep3 thank you ❤️

@TheBlackSheep3 TheBlackSheep3 deleted the feature/1762-swap-to-bwrap branch August 10, 2023 07:23
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
* switch from textwrap to bwrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch to bwrap
3 participants