Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit log filtering #1800

Merged
merged 3 commits into from
Aug 18, 2023
Merged

commit log filtering #1800

merged 3 commits into from
Aug 18, 2023

Conversation

extrawurst
Copy link
Owner

@extrawurst extrawurst commented Aug 9, 2023

TODO

  • search popup
  • highlight hits in log
  • select first hit relative to current selection once search result arrives
  • find bar in log (search term and number of hits)
  • only select search hits
  • substring search vs fuzzy

Post-MVP

  • show hits while still searching
  • search progress bar
  • highlight matches
  • benchmark log-walking vs scanning list of commit-ids

closes #1791

@extrawurst extrawurst force-pushed the fuzzy-filter-commit-log branch 2 times, most recently from 53c28fd to 22a6685 Compare August 11, 2023 14:46
@extrawurst extrawurst force-pushed the fuzzy-filter-commit-log branch 9 times, most recently from 34deaa8 to 4937d43 Compare August 16, 2023 10:46
@extrawurst

This comment was marked as outdated.

@extrawurst

This comment was marked as outdated.

proper state handling for log search

reduce cloning

cleanup

dont allow empty search, keep vec of results for ordering

cleaner interface of itembatch and clippy fixes

jump to closest hit

only select highlighted entries

allow closing search mode

simple search window

cleanup

show duration of search

give search bar look more attention

better phrasing for when search is still pending

support substring search

allow changing search options
@extrawurst extrawurst marked this pull request as ready for review August 18, 2023 15:17
@extrawurst
Copy link
Owner Author

this is good to go:
Screenflick Movie 10

@extrawurst extrawurst merged commit 3c5131a into master Aug 18, 2023
37 of 38 checks passed
@extrawurst extrawurst deleted the fuzzy-filter-commit-log branch August 18, 2023 15:19
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search/filter commit(s)
1 participant