Use helper binary for clipboard access (#262) #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrawurst
requested changes
Oct 10, 2020
| #[cfg(feature = "clipboard")] | ||
| pub fn copy_string(string: String) -> Result<()> { | ||
| fn execute_copy_command( | ||
| command: &mut Command, |
There was a problem hiding this comment.
we can take full ownership of command here.
cruessler
force-pushed
the
shell-out-for-clipboard
branch
3 times, most recently
from
e18c46b
to
ee6a377
Compare
Use `clip` on Windows, `pbcopy` on MacOX, `xclip` on Linux. - Remove dependency on `clipboard` - Remove feature `clipboard`
cruessler
force-pushed
the
shell-out-for-clipboard
branch
from
ee6a377
to
ea5985a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
clipon Windows,pbcopyon MacOX,xclipon Linux.Remove dependency on
clipboard.Closes #262.