Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide animation progress bar #1478

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Add option to hide animation progress bar #1478

merged 9 commits into from
Jun 21, 2024

Conversation

spevnev
Copy link
Contributor

@spevnev spevnev commented Jun 20, 2024

I've added option to hide animation bar as requested in #1465

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (8c007af) to head (5223f93).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1478   +/-   ##
=======================================
  Coverage   96.63%   96.64%           
=======================================
  Files         103      103           
  Lines        7729     7742   +13     
=======================================
+ Hits         7469     7482   +13     
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spevnev
Copy link
Contributor Author

spevnev commented Jun 21, 2024

@mwestphal Why did the coverage check fail saying that no token has been found? It surely looks like it is unrelated to my changes.

@mwestphal
Copy link
Contributor

@mwestphal Why did the coverage check fail saying that no token has been found? It surely looks like it is unrelated to my changes.

Indeed unrelated, codecov have some issues not yet fixed: codecov/feedback#112 (comment)

library/src/options.cxx Outdated Show resolved Hide resolved
doc/libf3d/OPTIONS.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small doc change needed

@mwestphal mwestphal merged commit 185e095 into f3d-app:master Jun 21, 2024
38 of 39 checks passed
@spevnev spevnev deleted the animation_progress_bar branch June 22, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants