Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectrum measurements #1446

Merged
merged 6 commits into from
Sep 25, 2022
Merged

Spectrum measurements #1446

merged 6 commits into from
Sep 25, 2022

Conversation

srcejon
Copy link
Collaborator

@srcejon srcejon commented Sep 25, 2022

This PR changes the Peak measurement patch, to add several different selectable spectrum measurements, including:

  • Peak
  • Channel power
  • Adjacent channel power
  • SNR
  • SNFR
  • THD
  • THD+N
  • SINAD
  • SFDR
  • (and None, for no measurement)

See the files changed for some example images and docs.

Note that I haven't yet changed the precision used for the peak, as I wanted the exact bin frequency, and you can't get this from the markers (it seems the spectrum isn't quite plotted on the bin frequency) - so I'll address that in a later patch. But for now, this at least restores the old appearance.

@f4exb
Copy link
Owner

f4exb commented Sep 25, 2022

I think the functionality is interesting but this is not something everyone will use every day so we have to think of something less prominent in the GUI. Also space on the top is scarce so maybe having a secondary display on the side in the case the display measurements is not "None" would be nicer moreover now that we can make the spectrum display as large as the screen size.

@f4exb f4exb merged commit a84f2c0 into f4exb:master Sep 25, 2022
@srcejon
Copy link
Collaborator Author

srcejon commented Sep 25, 2022

How about a simple measurements toggle icon in the controls GUI, that shows/hides a measurements widget that opens to the side as you suggest?

That would also have the benefit of being able to display SNR/THD/SINAD simultaneously which would be preferable anyway (along with a peak table, and a few other goodies I was thinking of adding later).

@f4exb
Copy link
Owner

f4exb commented Sep 25, 2022

This is how it looks like when spectrum display is minimized:
image

I think it needs a bit of refinement...

Edit:

How about a simple measurements toggle icon in the controls GUI, that shows/hides a measurements widget that opens to the side as you suggest?

Probably something along these lines yes

@f4exb
Copy link
Owner

f4exb commented Sep 25, 2022

This could also be a Rx channel on its own as we already have the Channel Analyzer.

@f4exb
Copy link
Owner

f4exb commented Sep 25, 2022

We definitely need more space for display and control. See this for source of inspiration: https://www.youtube.com/watch?v=ypu5glggyLI

@f4exb
Copy link
Owner

f4exb commented Sep 25, 2022

The resolution bandwidth us already displayed as a tool-tip over the FFT size selection combo box.

@srcejon
Copy link
Collaborator Author

srcejon commented Sep 25, 2022

This could also be a Rx channel on its own as we already have the Channel Analyzer.

But I would like the measurements to be available for all spectrum views. They're not all applicable in every case, but channel power can be used for TX, and THD might be used for audio spectra, etc.

@f4exb
Copy link
Owner

f4exb commented Sep 25, 2022

OK... that's a valid point and there is a spectrum display in the channel analyzer anyway so this can be used to isolate that spectrum display from the main spectrum avoiding collision with the other spectrum overlays like the channel markers.

Edit: so a sidekick widget engaged with a button on the controls (like the markers) is probably a good option. Moreover this would make the readings more readable. Probably we need to redefine the icons a little bit since the ruler icon would better suit the "measurements" button. Thus we can rather have a caliper icon for the calibration.

@srcejon
Copy link
Collaborator Author

srcejon commented Sep 25, 2022

Sounds good - I'll do an updated patch.

@srcejon srcejon deleted the spectrum_measurements branch December 22, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants