Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDRPlay RSP1B #1988

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Add SDRPlay RSP1B #1988

merged 3 commits into from
Feb 18, 2024

Conversation

wysiwyng
Copy link
Contributor

Adds support for the new RSP1B. I tried to add it wherever I found references to other SDRPlay devices, feel free to edit or message me if I missed something.

@f4exb f4exb requested a review from srcejon February 18, 2024 19:42
@f4exb
Copy link
Owner

f4exb commented Feb 18, 2024

Ubuntu build fails because of SDRplay API V3.14. Is the upgrade to 3.14 necessary?

@wysiwyng
Copy link
Contributor Author

to support the RSP1B, yes: https://www.sdrplay.com/api/

@srcejon
Copy link
Collaborator

srcejon commented Feb 18, 2024

to support the RSP1B, yes

Yep, that's why I updated it.

Ubuntu build fails

What's the error? It worked for me, although I didn't build from scratch. (I haven't tried with this patch yet though, but a quick scan through looks OK. Thanks @wysiwyng)

Will need to update Windows version too.

@srcejon
Copy link
Collaborator

srcejon commented Feb 18, 2024

Ok, I see the failure now. Will try to fix.

@srcejon
Copy link
Collaborator

srcejon commented Feb 18, 2024

Here's the PR for sdrangel-windows-libraries f4exb/sdrangel-windows-libraries#20 which should allow this patch to build on Windows.

@srcejon
Copy link
Collaborator

srcejon commented Feb 18, 2024

@wysiwyng can you add another change to this please?

In cmake/ci/build_sdrplay.sh, please change:

sudo yes | sh install_lib.sh

To

sudo yes | bash install_lib.sh

@srcejon
Copy link
Collaborator

srcejon commented Feb 18, 2024

I think the external/windows link needs updating to the latest hash.

@f4exb f4exb merged commit 6c4789d into f4exb:master Feb 18, 2024
1 check passed
@wysiwyng wysiwyng deleted the add_rsp1b branch February 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants