Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cleanup #2184

Merged
merged 14 commits into from
Jun 24, 2024
Merged

Fix/cleanup #2184

merged 14 commits into from
Jun 24, 2024

Conversation

dforsi
Copy link
Contributor

@dforsi dforsi commented Jun 23, 2024

This PR:

  • removes some unused code:
    • plugins/feature/map/mapfmlistdialog.ui doesn't seem to be used anywhere, however it would be interesting to see it implemented
    • sdrgui/gui/rollupwidget.{cpp,h}' don't seem to be used anywhere (the class that is actually used is names RollupContents` and its files are very similar to these deleted)
    • some calls to unlock and some includes related to QMutexLocker
  • fixes some typos in the swagger documentation and in a readme
  • applies some changes made automatically by Qt Creator that don't seem to change the appearance of the widgets
    • fix of a class name
    • removal of unused resources
    • changes to fonts (font name, size and wieght)

I'm not able to regenerate the html2 docs maybe because the generate.sh script doesn't seem up to date because it is trying to edit .yaml files under sdrbase but there are none.

dforsi added 14 commits June 23, 2024 17:32
The mutex will get unlocked anyway when falling out of scope.
Fixes:
 sdrgui/device/deviceuiset.cpp:353:36: 2nd function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
Automatically deleted by opening the .ui file in Qt Creator.
Automatically updated by opening the .ui file in Qt Creator.
Automatically updated by opening the .ui file in Qt Creator.
@f4exb
Copy link
Owner

f4exb commented Jun 23, 2024

@srcejon I am not sure plugins/feature/map/mapfmlistdialog.ui should be removed. Maybe you had in the plans to implement this and we should save the effort of making up the dialog (although git would still remember it)

@f4exb
Copy link
Owner

f4exb commented Jun 23, 2024

Building files from the .yaml Swagger definitions is done following these instructions: https://github.com/f4exb/sdrangel/tree/master/swagger/docker

@srcejon
Copy link
Collaborator

srcejon commented Jun 24, 2024

@srcejon I am not sure plugins/feature/map/mapfmlistdialog.ui should be removed. Maybe you had in the plans to implement this and we should save the effort of making up the dialog (although git would still remember it)

I was planning to import data from www.fmlist.org - but the owner of that site seems to have gone quiet, so probably wont happen. As you say, I can always dig up from git later.

@f4exb f4exb merged commit a4b78fa into f4exb:master Jun 24, 2024
3 checks passed
@dforsi dforsi deleted the fix/cleanup branch July 12, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants