Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #47

Merged
merged 18 commits into from
Nov 16, 2022
Merged

Improve test coverage #47

merged 18 commits into from
Nov 16, 2022

Conversation

lquerel
Copy link
Contributor

@lquerel lquerel commented Nov 13, 2022 •
edited
Loading

Test coverage improvements (#40):

  • More tests for the metrics (optional description, unit, sum, min, max)
  • Description of the testing and validation plan (see README.md)

In addition to test coverage, this PR also updated

  • the metrics benchmark CLI tool,
  • the arrow_record package to make the new metrics encoder/decoder accessible for the experimental collector.

@lquerel lquerel linked an issue Nov 13, 2022 that may be closed by this pull request
Improve test coverage #40
Closed
2 tasks
@lquerel lquerel added the test label Nov 13, 2022
@lquerel lquerel self-assigned this Nov 13, 2022
@lquerel lquerel added this to the Beta V1 milestone Nov 13, 2022
@lquerel lquerel marked this pull request as ready for review November 16, 2022 02:24
jmacd
jmacd approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggested expression simplifications.

README.md Show resolved Hide resolved
pkg/datagen/data_generator.go Outdated Show resolved Hide resolved
pkg/datagen/data_generator.go Outdated Show resolved Hide resolved
pkg/datagen/data_generator.go Outdated Show resolved Hide resolved
lquerel and others added 5 commits November 16, 2022 10:45
@lquerel @jmacd
Update pkg/datagen/data_generator.go
398a53a 
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
@lquerel @jmacd
Update pkg/datagen/data_generator.go
d156ead 
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
@lquerel @jmacd
Update pkg/datagen/data_generator.go
68e6152 
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
@lquerel
Update README.md intro section
c25052d
@lquerel
Merge remote-tracking branch 'origin/40-improve-test-coverage' into 4…
d2b6e95 
…0-improve-test-coverage
@lquerel lquerel merged commit fe20704 into main Nov 16, 2022
@jmacd jmacd mentioned this pull request Nov 16, 2022
Merged
@jmacd jmacd deleted the 40-improve-test-coverage branch April 7, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

Assignees

@lquerel lquerel

Labels
test
Projects
OTel Arrow Protocol
Status: Done
Milestone
Beta V1
Development

Successfully merging this pull request may close these issues.

Improve test coverage
2 participants
@lquerel @jmacd