Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support docker run --platform #1641

Closed
chonton opened this issue Feb 14, 2023 · 6 comments · Fixed by #1642
Closed

Support docker run --platform #1641

chonton opened this issue Feb 14, 2023 · 6 comments · Fixed by #1642
Assignees
@chonton

Comments

@chonton
Copy link
Contributor

chonton commented Feb 14, 2023

Description

docker run has an argument --platform which explicitly specifies the platform image to use. Support configuring this parameter in the start mojo

Info

  • docker-maven-plugin version : 0.42
  • Maven version (mvn -v) : 3.9.0
  • Docker version : 20.10.22
  • If it's a feature request, what is your use case : Support the --platform argument for docker run
@chonton chonton mentioned this issue Feb 14, 2023
Merged
rohanKanojia pushed a commit that referenced this issue Feb 15, 2023
@rohanKanojia
Support --platform argument for docker start
25398b0 
closes #1641
@chonton
Copy link
Contributor Author

chonton commented Feb 16, 2023

@rohanKanojia Thanks for merging. Any plans for a release soon?

@rohanKanojia
Copy link
Member

I just had published a release last week. Is it okay if I delay it to the end of this month? Or do you need this urgently? (I can try releasing this weekend)

@chonton
Copy link
Contributor Author

chonton commented Feb 16, 2023

End of month is fine. Thanks.

@chonton
Copy link
Contributor Author

chonton commented Feb 27, 2023

@rohanKanojia Ready to release?

@rohanKanojia
Copy link
Member

@chonton : Let me cut a release tonight

@rohanKanojia
Copy link
Member

@chonton : v0.42.0 should be available on maven central now. Could you please test it to see everything is as per your expectations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chonton chonton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support --platform argument for docker start
2 participants
@chonton @rohanKanojia