Add no-cache functionality into Buildx.

[tadgh]

Heya, I noticed that running a multiplatform build (which uses buildx) ignores the configured no-cache directive. e.g. this pom.xml

						<configuration>

							<pullRegistry>docker.io</pullRegistry>
							<pushRegistry>${docker.registry}</pushRegistry>

							<images>
								<image>
									<name>blah</name>
									<build>
										<noCache>true</noCache>
										<buildx>
											<platforms>
												<platform>linux/arm64</platform>
												<platform>linux/amd64</platform>
											</platforms>
										</buildx>
										<contextDir>${project.basedir}/target/dockercontext</contextDir>
									</build>
								</image>
							</images>
						</configuration>

was not actually passing down --no-cache to the buildx command.

This PR causes the top-level build option to be passed down to buildx if buildx happens to be used. Note that the check for no-cache is copy-pasted from your existing implementation. I didn't want to do guesswork about where utility classes should live. If you'd like me to move it, please let me know where to move it to. I would truly appreciate it if this could be merged and released, as I'm using a fork at my organization at the moment 😅

Cheers,

--Gary

[codecov]

Codecov Report

Merging #1717 (2c48d52) into master (f228f64) will increase coverage by 0.00%.
The diff coverage is 70.00%.

❗ Current head 2c48d52 differs from pull request most recent head 5eb4594. Consider uploading reports for the commit 5eb4594 to get more accurate results

@@            Coverage Diff            @@
##             master    #1717   +/-   ##
=========================================
  Coverage     65.11%   65.11%           
- Complexity     2253     2254    +1     
=========================================
  Files           172      172           
  Lines         10109    10111    +2     
  Branches       1390     1391    +1     
=========================================
+ Hits           6582     6584    +2     
  Misses         2977     2977           
  Partials        550      550           

Files	Coverage Δ
.../io/fabric8/maven/docker/service/BuildService.java	64.14% <100.00%> (+0.18%)	⬆️
...io/fabric8/maven/docker/service/BuildXService.java	75.97% <100.00%> (+0.27%)	⬆️
...a/io/fabric8/maven/docker/config/ConfigHelper.java	89.39% <57.14%> (-3.83%)	⬇️

[rhuss]

Thanks for the PR! It looks good to me, but as you said, we should move it to an utility method and maybe even consider to finally remove the docker.nocache option since this was deprecated since quite some time (I think it even has been already removed from the documentation).

@rohanKanojia since I'm quite disconnected from the codebase since quite some time, could you propose a proper location for a static method to this 'noCache' check ?

[rohanKanojia]

Shall we try to move this method as a static method in io.fabric8.maven.docker.config.ConfigHelper? Otherwise we can also create a new class ImageConfigurationUtil or ImageConfigurationHelper for moving this method?

[tadgh]

I've migrated the method and renamed it a bit, hopefully that is alright. Let me know if there's anything else I can do. Cheers

[rohanKanojia]

Shall we mention nocache functionality in buildx documentation as well?

[tadgh]

Shall we mention nocache functionality in buildx documentation as well?

It's documented in the <build> section, and <buildx> is a subsection. It feels to me as though the docs in the top-level build section may be enough, but maybe it's worth a specific callout? It isn't really a new option, its more that an option that previously existed wasn't being applied correctly. Happy to go either way on this, if you want to guide me on what type of docs you want written.

Also, I've added a changelog.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

65.0% Coverage
0.0% Duplication

The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[rohanKanojia]

It isn't really a new option, its more that an option that previously existed wasn't being applied correctly.

Umm, that makes sense. As a user, I would expect existing option to work with buildx too

[tadgh]

Thanks much! Excited to get this merged :)