Skip to content

Commit

Permalink
Merge pull request #185 from richm/update-to-2.3.0
Browse files Browse the repository at this point in the history
use kubeclient 4.4.latest; refactor tests for k8s api discovery
  • Loading branch information
richm committed Aug 26, 2019
2 parents ce981b4 + 898b193 commit a055a1c
Show file tree
Hide file tree
Showing 16 changed files with 615 additions and 1,110 deletions.
4 changes: 2 additions & 2 deletions fluent-plugin-kubernetes_metadata_filter.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)

Gem::Specification.new do |gem|
gem.name = "fluent-plugin-kubernetes_metadata_filter"
gem.version = "2.2.0"
gem.version = "2.3.0"
gem.authors = ["Jimmi Dyson"]
gem.email = ["jimmidyson@gmail.com"]
gem.description = %q{Filter plugin to add Kubernetes metadata}
Expand All @@ -21,7 +21,7 @@ Gem::Specification.new do |gem|

gem.add_runtime_dependency 'fluentd', ['>= 0.14.0', '< 2']
gem.add_runtime_dependency "lru_redux"
gem.add_runtime_dependency "kubeclient", "~> 1.1.4"
gem.add_runtime_dependency "kubeclient", '< 5'

gem.add_development_dependency "bundler", "~> 1.3"
gem.add_development_dependency "rake"
Expand Down
3 changes: 1 addition & 2 deletions lib/fluent/plugin/filter_kubernetes_metadata.rb
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def fetch_namespace_metadata(namespace_name)
metadata = parse_namespace_metadata(metadata)
@stats.bump(:namespace_cache_api_updates)
log.trace("parsed metadata for #{namespace_name}: #{metadata}") if log.trace?
@namespace_cache[metadata['namespace_id']] = metadata
@namespace_cache[metadata['namespace_id']] = metadata
return metadata
rescue Exception => e
log.debug(e)
Expand Down Expand Up @@ -164,7 +164,6 @@ def log.trace?
end

require 'kubeclient'
require 'active_support/core_ext/object/blank'
require 'lru_redux'
@stats = KubernetesMetadata::Stats.new

Expand Down
26 changes: 26 additions & 0 deletions lib/fluent/plugin/kubernetes_metadata_common.rb
Original file line number Diff line number Diff line change
Expand Up @@ -111,3 +111,29 @@ def syms_to_strs(hsh)

end
end

# copied from activesupport
class Object
# An object is blank if it's false, empty, or a whitespace string.
# For example, +nil+, '', ' ', [], {}, and +false+ are all blank.
#
# This simplifies
#
# !address || address.empty?
#
# to
#
# address.blank?
#
# @return [true, false]
def blank?
respond_to?(:empty?) ? !!empty? : !self
end

# An object is present if it's not blank.
#
# @return [true, false]
def present?
!blank?
end
end
34 changes: 0 additions & 34 deletions test/cassettes/kubernetes_docker_metadata_annotations.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 0 additions & 34 deletions test/cassettes/kubernetes_docker_metadata_dotted_labels.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

193 changes: 193 additions & 0 deletions test/cassettes/kubernetes_get_api_v1.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit a055a1c

Please sign in to comment.