Bz1464020 fix memory definition #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcantrill
force-pushed
the
bz1464020_fix_memory_definition
branch
from
bf1c51d
to
1be8b2f
Compare
richm
reviewed
Jun 28, 2017
run.sh
Outdated
| @@ -30,8 +30,7 @@ if echo "${OCP_AUTH_PROXY_MEMORY_LIMIT:-}" | grep -qE "^([[:digit:]]+)([GgMm])?i | |||
| num="${DEFAULT_MIN}" | |||
| fi | |||
|
|
|||
| NODE_OPTIONS="--max-old-space-size=$((num / BYTES_PER_MEG))" | |||
| export NODE_OPTIONS | |||
| export NODE_OPTIONS="--max_old_space_size=$((num / ${BYTES_PER_MEG}))" | |||
There was a problem hiding this comment.
Might I make a simple suggestion that will allow passing in node options from the dc:
export NODE_OPTIONS="${NODE_OPTIONS:---max_old_space_size=$((num / ${BYTES_PER_MEG}))}"
Then users can set NODE_OPTIONS in the env. in the dc to override this and/or provide additional options.
richm
approved these changes
Jun 28, 2017
jcantrill
force-pushed
the
bz1464020_fix_memory_definition
branch
from
1be8b2f
to
84deaa0
Compare
jcantrill
force-pushed
the
bz1464020_fix_memory_definition
branch
from
84deaa0
to
8440ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bz1464020 to supply memory limits to the node run time. Changing to underscore from dashes based on grep'ing the code and:
[1] nodejs/node#7937
[2] elastic/kibana#9006