Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Firefox+Firebug error: 'setting a property that has only a getter' #4

Closed
wants to merge 1 commit into from
Closed

Fix for Firefox+Firebug error: 'setting a property that has only a getter' #4

wants to merge 1 commit into from

Conversation

joshvarner
Copy link

The following error is reported when using Firebug v1.6X.0b1 on Firefox 3.6.10:

setting a property that has only a getter (all.js line 5)

It looks like Firefox doesn't like having console reassigned to anything, even if it's to its current value. This pull request has a fix. Note: I didn't update the uglify minified version, as I do not have that particular minifier.

@kangax
Copy link
Member

kangax commented Oct 7, 2010

Thanks for the patch.

I was actually thinking of removing that part where console is being redefined, and instead provide fabric.log, and fabric.warn methods. This would make it easier to mock them when testing (since console.* methods are read-only in some environments). It's also not the best idea to redefine non-standard host object like console: other scripts in the document could expect console.log to have different signature; it could be made read-only in some unknown/future environments, etc.

@kangax
Copy link
Member

kangax commented Oct 11, 2010

Fixed in http://github.com/kangax/fabric.js/commit/e70830f7d64a2dda2b08e6768e7869bfba2732ee

kangax pushed a commit that referenced this pull request Jul 19, 2014
@asturur
Merge pull request #4 from kangax/master
cc83028 
sync to head
@sarath-prohaktiv sarath-prohaktiv mentioned this pull request May 16, 2015
Closed
@Terry-Fedirko Terry-Fedirko mentioned this pull request May 19, 2015
Closed
This was referenced May 27, 2015
Closed
Closed
@sarath-prohaktiv sarath-prohaktiv mentioned this pull request Jun 25, 2015
Closed
@sarath-prohaktiv sarath-prohaktiv mentioned this pull request Aug 12, 2015
Open
asturur added a commit that referenced this pull request Dec 7, 2015
@asturur
Merge pull request #4 from kangax/master
c461792 
update to master
WietseWind added a commit to WietseWind/fabric.js that referenced this pull request Sep 19, 2017
@WietseWind
Fix IE rendering of SVG as overlay image fabricjs#4 - Moved to method…
1c7ba51 
… 'loadImageInDom'
asturur pushed a commit that referenced this pull request Sep 29, 2017
@WietseWind @asturur
Fix IE rendering of SVG as overlay image (#4324)
052631b 
* Fix IE rendering of SVG as overlay image

* Fix IE rendering of SVG as overlay image #2 - Fix coding syntax (CI)

* Fix IE rendering of SVG as overlay image #3 - Fix coding syntax (CI)

* Fix IE rendering of SVG as overlay image #4 - Moved to method 'loadImageInDom'

* Fix IE rendering of SVG as overlay image #5 - Moved some stuff around

* Fix IE rendering of SVG as overlay image #6 - Fixed the setTimeout (removed)

* Update misc.js
birdage pushed a commit to birdage/fabric.js that referenced this pull request Jun 19, 2018
@tbolis
Merge pull request fabricjs#4 from tbolis/react-15-upgrade
c81fc9b 
React 15 upgrade
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshvarner @kangax