Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types/ControlProps.ts: add missing @defaults, minor #9956

Merged
merged 2 commits into from
Jul 1, 2024
Merged

types/ControlProps.ts: add missing @defaults, minor #9956

merged 2 commits into from
Jul 1, 2024

Conversation

mrienstra
Copy link
Contributor

@mrienstra mrienstra commented Jun 30, 2024 •
edited
Loading

I noticed hasControls was lacking a defined default value, this PR adds that.

Unless perhaps src/shapes/Object/types/ControlProps.ts is generated automatically somehow?

Default value of true as per:
https://github.com/fabricjs/fabric.js/blob/55438be/src/shapes/Object/defaultValues.ts#L106

Edit: I also:

  1. Changed cornerStrokeColor default from null to '', also as per defaultValues.ts
  2. Changed cornerStyle default from rect to 'rect'
  3. Added missing default of null to cornerDashArray

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jun 30, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@asturur asturur merged commit 7cbd288 into fabricjs:master Jul 1, 2024
19 of 24 checks passed
@mrienstra mrienstra deleted the patch-2 branch July 1, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrienstra @asturur