Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Licensing in autogenerated code #17

Closed
lacker opened this issue Jul 18, 2016 · 3 comments
Closed

Licensing in autogenerated code #17

lacker opened this issue Jul 18, 2016 · 3 comments
Milestone
0.1.0

Comments

@lacker
Copy link
Contributor

lacker commented Jul 18, 2016

The autogenerated code says "copyright facebook according to the license in the root of this repo". However, that code won't actually go into a FB project. And there is no license at the root of the repo. Should we remove that?
@gaearon
Copy link
Contributor

gaearon commented Jul 18, 2016

Whoops. 😄
We should, definitely.

The way we copy the configs by itself is hacky.
We shouldn’t have to need isInNodeModules.
Instead, some sort of string replacement should take place, I think.

@vjeux
Copy link
Contributor

vjeux commented Jul 18, 2016

When we eject, we should strip all the fb licenses

@gaearon gaearon added this to the 0.1.0 milestone Jul 18, 2016
@vjeux
Copy link
Contributor

vjeux commented Jul 18, 2016

fa00c77

@vjeux vjeux closed this as completed Jul 18, 2016
stayradiated pushed a commit to stayradiated/create-react-app that referenced this issue Nov 13, 2016
@kitze
Merge pull request facebook#17 from stereobooster/16-fix-eject
c09c146 
Fix for facebook#16 fix eject script
@sverhoeven sverhoeven mentioned this issue Nov 14, 2016
Closed
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
3 participants
@lacker @vjeux @gaearon