Don't run yarn after ejecting #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2017
Closed
ro-savage
reviewed
Jun 27, 2017
| @@ -220,8 +220,21 @@ inquirer | |||
| } | |||
|
|
|||
| if (fs.existsSync(paths.yarnLockFile)) { | |||
There was a problem hiding this comment.
Shouldn't the whole if statement be commented out and it just runs spawnSync('npm', ['install'], { stdio: 'inherit' }); every time?
There was a problem hiding this comment.
If somebody has a lockfile they're likely using Yarn for development. Which means the versions they currently get might be more strict than allowed per semver. Running npm install on top risks giving them more fresh versions.
There was a problem hiding this comment.
Then looks like a perfectly reasonable temp fix to me.
romaindso
pushed a commit
to romaindso/create-react-app
that referenced
this pull request
Jul 10, 2017
wmonk
referenced
this pull request
in wmonk/create-react-app-typescript
Aug 7, 2017
morgs32
pushed a commit
to BrickworkSoftware/create-react-app
that referenced
this pull request
Sep 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2624 and work around #2030.
Obviously it's not a very good workaround, but I'm running out of options and we need the CI to be working. The reason I'm okay with this solution is because current behavior is broken anyway. Re-running
yarnmakes no difference since we didn't change the lockfile, so it might as well be a no-op.See #2627 for discussion of the proper fix.