Move favicon.ico <link> to accommodate Chrome #4891
Conversation
Chrome requests `favicon.ico` on every route change, but stops if the `<link>` for it occurs early enough in the page. [Several](https://stackoverflow.com/questions/35409588/favicon-requested-on-every-route-change) other [people](ctrlplusb/react-universally#145) have been running into this issue since at least February 2016.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
I just signed the CLA. Is it just me, or are the CI failures unrelated to my change? |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@thejohnfreeman it's unrelated, #4890 should fix the CI 👍 |
|
/cc @jeffposnick is this a thing? |
|
It's not something that I've heard folks complain about. I'd recommend folks who can reproduce the behavior and believe it's a bug in Chrome to open an issue at https://crbug.com with details. That being said, this seems like a harmless change to make in |
Chrome requests `favicon.ico` on every route change, but stops if the `<link>` for it occurs early enough in the page. [Several](https://stackoverflow.com/questions/35409588/favicon-requested-on-every-route-change) other [people](ctrlplusb/react-universally#145) have been running into this issue since at least February 2016.
Chrome requests
favicon.icoon every route change, but stops if the<link>for it occurs early enough in the page. Several other people have been running into this issue since at least February 2016.