Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the correct dependency for babel-plugin-dynamic-import-node #4984

Merged
merged 2 commits into from
Oct 14, 2018

Conversation

vikr01
Copy link
Contributor

@vikr01 vikr01 commented Sep 8, 2018

babel-plugin-transform-dynamic-import was just a copy of babel-plugin-dynamic-import-node, and it's not been updated for a while while babel-plugin-dynamic-import-node has.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer
Copy link
Contributor

Timer commented Sep 8, 2018

This was intentional because the package you switched to does not support Babel 7. When it supports Babel 7, we're more than happy to switch back to it!

@vikr01
Copy link
Contributor Author

vikr01 commented Sep 9, 2018

Makes sense.

PR'd airbnb/babel-plugin-dynamic-import-node#64

@bjankord
Copy link

Would love to see this in the v2.0.0 stable release if possible. Currently, @vikr01 is waiting on some PR's downstream to be reviewed/merged by the airbnb team.

@Timer
Copy link
Contributor

Timer commented Sep 25, 2018

This isn't going to stop us from releasing 2.0.0 as stable, as we already updated our fork of this plugin to be babel 7 compatible.
This change can be released in a patch version from our end, though.

@wolfy1339
Copy link

wolfy1339 commented Oct 9, 2018

Now that v2.2 of babel-plugin-dynamic-import-node added support for Babel v7 (while still maintaining v6 compatibility), this can be updated and merged

@Timer
Copy link
Contributor

Timer commented Oct 9, 2018

Excellent, thanks for letting us know!

@Timer Timer added this to the 2.0.5 milestone Oct 9, 2018
packages/babel-preset-react-app/create.js Outdated Show resolved Hide resolved
@vikr01 vikr01 force-pushed the fix/babel-plugin-dynamic-import-node branch from 0c1f990 to 6b1cdf3 Compare October 9, 2018 01:18
@vikr01 vikr01 changed the base branch from next to master October 9, 2018 01:18
@vikr01 vikr01 force-pushed the fix/babel-plugin-dynamic-import-node branch from 6b1cdf3 to 56b4ae5 Compare October 9, 2018 01:20
@vikr01
Copy link
Contributor Author

vikr01 commented Oct 9, 2018

Updated the version for babel-plugin-dynamic-import-node and changed target branch/rebased against master, since that seems to be what's current.

@gaearon gaearon merged commit 52fcb23 into facebook:master Oct 14, 2018
@vikr01 vikr01 deleted the fix/babel-plugin-dynamic-import-node branch November 3, 2018 21:00
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants