Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always lint with latest React version #5043

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Always lint with latest React version #5043

merged 1 commit into from
Sep 20, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Sep 20, 2018 •
edited
Loading

This is the best behavior so people have seamless upgrades to new React majors.

This is probably a terrible default warning from the ESLint plugin, and we need to wait for jsx-eslint/eslint-plugin-react#1955 before changing this hardcoded behavior.

Closes #5034

@Timer
Always lint with latest React version
dd39f85 
This is the best behavior so people have seamless upgrades to new React majors.

This is probably a terrible default and warning from the ESLint plugin, and we need to wait for jsx-eslint/eslint-plugin-react#1955 before changing this hardcoded behavior.

Closes facebook#5034
@Timer Timer added this to the 2.0.0 milestone Sep 20, 2018
@Timer Timer merged commit 4abc5c4 into facebook:next Sep 20, 2018
@Timer Timer deleted the feature/fix-annoying-warning branch September 20, 2018 15:58
@gaearon
Copy link
Contributor

gaearon commented Sep 20, 2018

lol ok

@Timer
Copy link
Contributor Author

Timer commented Sep 20, 2018 •
edited
Loading

The old behavior was to lint against latest, we could talk about matching it to the package.json version but then people won't get warnings about unsafe lifecycles, so I think latest is good.

Without this patch console output was ugly:

joes-mbp:website joe$ yarn build
yarn run v1.9.4
$ react-app-rewired build
Creating an optimized production build...
Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.
Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.
Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.
Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.
Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.
Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.
Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.
Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.
Compiled with warnings.

edit: they don't support latest so 999.999.999 is the next best thing because why not

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@Timer
Always lint with latest React version (facebook#5043)
42e5669 
This is the best behavior so people have seamless upgrades to new React majors.

This is probably a terrible default warning from the ESLint plugin, and we need to wait for jsx-eslint/eslint-plugin-react#1955 before changing this hardcoded behavior.

Closes facebook#5034
GabeDuarteM added a commit to GabeDuarteM/gd-scripts that referenced this pull request Oct 29, 2018
@GabeDuarteM
fix(lint): always use the latest react version to lint
9552193 
see facebook/create-react-app#5043
@existentialism existentialism mentioned this pull request Jan 4, 2019
Closed
@ianschmitz ianschmitz mentioned this pull request Jan 5, 2019
Merged
@lock lock bot locked and limited conversation to collaborators Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: bug fix tag: internal
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Timer @gaearon @facebook-github-bot