Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip flow syntax before any other transform #5182

Merged
merged 2 commits into from
Oct 1, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Sep 30, 2018

Plugins run before presets so we can't use the flow preset

As pointed out by @gaearon, this would be the natural order if the browser supported class properties (or any other transform).

Fixes #5176

Plugins run before presets so we can't use the flow preset
@Timer Timer added this to the 2.0.0 milestone Sep 30, 2018
].filter(Boolean),
plugins: [
// Strip flow types before any other transform, emulating the behavior
// order as-if the browser supported all of the succeeding features
isFlowEnabled &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's link to the issue here

Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified it fixes the issue?

@Timer
Copy link
Contributor Author

Timer commented Oct 1, 2018

Yes, it fixed the issue. 😄

@Timer Timer merged commit 72d4ab0 into facebook:master Oct 1, 2018
@Timer Timer mentioned this pull request Oct 1, 2018
@Timer Timer deleted the flow-before-class-properties branch October 1, 2018 00:06
@Timer
Copy link
Contributor Author

Timer commented Oct 1, 2018

See e2e #5183

@brunolemos brunolemos mentioned this pull request Oct 2, 2018
11 tasks
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants