Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for TypeScript install in preflight #5516

Merged
merged 2 commits into from
Oct 21, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Oct 21, 2018

This ensures TypeScript is installed when a tsconfig.json is present (this is our trigger to perform type checking).

image

@Timer Timer added this to the 2.1 milestone Oct 21, 2018
@Timer Timer merged commit 7ba343c into facebook:master Oct 21, 2018
@Timer Timer deleted the typescript/preflight branch October 22, 2018 11:50
@brunolemos brunolemos mentioned this pull request Oct 22, 2018
3 tasks
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
* Check for TypeScript install in preflight

* Remove unused import
nate770 pushed a commit to ONTW/create-react-app that referenced this pull request Oct 30, 2018
* Check for TypeScript install in preflight

* Remove unused import
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants