Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running npm install from create-react-app command and init script on Windows #6

Merged
merged 1 commit into from
Jul 17, 2016
Merged

Fix running npm install from create-react-app command and init script on Windows #6

merged 1 commit into from
Jul 17, 2016

Conversation

insin
Copy link
Contributor

@insin insin commented Jul 17, 2016

No description provided.

@ghost
Copy link

ghost commented Jul 17, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@vjeux
Copy link
Contributor

vjeux commented Jul 17, 2016

Have you actually tried to run it on windows? Or is it just an educated guess that it is not working?

@vjeux vjeux merged commit 5c7217d into facebook:master Jul 17, 2016
@insin
Copy link
Contributor Author

insin commented Jul 17, 2016

You get Error: spawn npm ENOENT on both install attempts on Windows - these changes got me through to the end of the create-react-app command.

@vjeux
Copy link
Contributor

vjeux commented Jul 17, 2016

Nice!

@insin insin deleted the windows-npm-installs branch July 17, 2016 20:28
vjeux pushed a commit that referenced this pull request Jul 18, 2016
@gaearon gaearon mentioned this pull request Jul 21, 2016
mikechau pushed a commit to mikechau/create-react-app that referenced this pull request Jan 25, 2017
Removed references to eslint and updated README closes facebook#6
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants