Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust typescript-eslint to not warn about typedefs when used before defined #7079

Merged
merged 2 commits into from
May 20, 2019

Conversation

vincentjames501
Copy link
Contributor

The new ESLint TS rules are a little cumbersome for typedefs. We have 100s of places where we do things like the following as we like to have our types declared at the top of our files.

export type AppProps = ReturnType<typeof mapStateToProps> & typeof mapDispatchToProps;
export const mapStateToProps = (state: RootState) => ({  initialized: state.initialized });
export const mapDispatchToProps = { initialize };

Making the changes here in local eslint-config-react-app/index.js fixes the warnings for TS(X) files.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 3.0.2 milestone May 20, 2019
@ianschmitz
Copy link
Contributor

Thanks for the PR!

@ianschmitz ianschmitz merged commit bdaccf7 into facebook:master May 20, 2019
@lock lock bot locked and limited conversation to collaborators May 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants