Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pnpm package manager #7791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

macjabeth
Copy link

@macjabeth macjabeth commented Oct 7, 2019

Hello! I was researching if CRA had any support for the pnpm package manager. I came across issue #2809 and - per the last comment - decided to try and tackle this implementation myself.

This is my initial pull request, and I know it still needs some work because I tested it myself and after there are some issues still. I'm hoping by creating this PR, it'll get a discussion going on how to properly implement this.

Thank you for considering this feature!

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mrmckeb
Copy link
Contributor

mrmckeb commented Oct 9, 2019

Hi @macjabeth, thanks for spending the time on this. In future, I'd recommend that you raise an issue first just to ensure this work isn't being tackled by someone else - we don't ever want people to waste time...

We're about to roll out a new feature in the coming weeks, and this PR would conflict with that... if you're OK with it, could we fix conflicts and merge this in after PR that is merged?

@mrmckeb mrmckeb self-assigned this Oct 9, 2019
@mrmckeb mrmckeb added this to the 3.3 milestone Oct 9, 2019
@macjabeth
Copy link
Author

@mrmckeb Of course! Sorry for not raising an issue first... Would be happy waiting until then and resolving any conflicts.

@mrmckeb
Copy link
Contributor

mrmckeb commented Oct 10, 2019

If you can subscribe to #7716, we can resume this PR as soon as that's merged. I hope next week, as I'll spend Monday finishing it off.

@arzga
Copy link

arzga commented Mar 11, 2020

Would love to see this improvement to make it to the master ;)

@ZachHaber
Copy link

Is there anything I can do to help get this added?

@beenotung
Copy link

beenotung commented Jul 2, 2020

@ZachHaber Is there anything I can do to help get this added?

I guess we'd better re-apply changes made by @macjabeth based on the current master branch?

In the meantime, I created a script in my PATH named npm, which call pnpm $@ ...

@alex-shamshurin
Copy link

Is there any progress and chances to merge it?

@amyrlam amyrlam removed their request for review August 24, 2020 05:38
@adelarsq
Copy link

Any update on this?

@nyn3x
Copy link

nyn3x commented Feb 4, 2021

Is there any update on this? I would very much like this feature to be in CRA ...

@DylanCulfogienis
Copy link

Any news on this?

@beenotung
Copy link

For folks still waiting for pnpm support from create-react-app, I made an alternative npm init script that can work with any package managers.
git npm

@ashishbinu
Copy link

Hope it gets implemented soon

@ruifortes
Copy link

Hey!! Facebook!! Could you?!? Hum. hum??

Copy link

@adelarsq adelarsq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a little review and appears that is fine. But has some conflicts to solve since it's an old request.

@Philzen
Copy link

Philzen commented Feb 2, 2022

Any update on this?

@karlhorky
Copy link

For those who want to go down with the ship (create-react-app is going away, try googling if you don't know what I mean), here's a version that you can use which uses pnpm internally:

pnpm create @upleveled/react-app my-app

@beenotung
Copy link

If you just want to create a typescript react app, instead of a generic creator with multiple template options. You can run:

npm init react-ts-template

Or

npx create-react-ts-template

It will create the project for you (without installing the dependencies)

You can then cd into the project directory and install with any package manager, e.g.

cd my-app
pnpm i

@CoolPlayLin
Copy link

Hello @macjabeth
This Pull Request has been open for 3 years. Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.