Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade outdated packages #7814

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Upgrade outdated packages #7814

merged 1 commit into from
Oct 25, 2019

Conversation

andriijas
Copy link
Contributor

@andriijas andriijas commented Oct 12, 2019 •
edited
Loading

  • Bumping packages with minor/backwards compatible releases.
  • Went through each package with major release and verified checklogs - most just drops support for node versions prior 8.9

Some packages with major releases needs to be verified in separate PR in react-dev-tools

@ianschmitz
Copy link
Contributor

Looks like you're running into the same issue i was with a newer version of webpack-dev-server: #7473 (comment)

@iansu @mrmckeb we talked about unpinning some packages in next release. Are we alright unpinning in this PR?

@ianschmitz ianschmitz self-assigned this Oct 14, 2019
@andriijas andriijas changed the title Bump minors Upgrade outdated packages Oct 15, 2019
@andriijas
Copy link
Contributor Author

@ianschmitz Yeah and I forgot to update the PR description. Let me know about the pinning and i adjust

@iansu
Copy link
Contributor

iansu commented Oct 16, 2019

I think our plan was to try out unpinning everything in a beta. Which will likely be 4.0 at this point.

@andriijas
Copy link
Contributor Author

@iansu i updated the PR holding back webpack-dev-server for now and tests are passing. I can see if i can pinpoint the version in separate PR.

@ianschmitz ianschmitz added this to the 3.2.1 milestone Oct 16, 2019
ianschmitz
ianschmitz suggested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@ianschmitz ianschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you go through the other packages and make sure we're synced? For example babel-preset-react-app needs to be bumped as well.

@andriijas
Copy link
Contributor Author

@iansu Done. Going to check why the docs deploy test failed.

There are more packages to upgrade but they contain incompatible changes so let's do that in separate PR

@iansu iansu modified the milestones: 3.2.1, 3.3 Oct 23, 2019
@andriijas
Copy link
Contributor Author

@ianschmitz rebased and I went ahead and checked through each webpack-dev-server version. Unfortunately the issue discussed in the linked issue above was introduced already with 3.3.0 so we need to stick with 3.2.1 for now unless we have another way around

This was referenced Oct 24, 2019
Merged
Merged
@andriijas andriijas merged commit 324428f into facebook:master Oct 25, 2019
@andriijas andriijas deleted the bump branch October 25, 2019 08:36
@mjsarfatti mjsarfatti mentioned this pull request Oct 28, 2019
Closed
@lock lock bot locked and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ianschmitz ianschmitz ianschmitz approved these changes

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees

@ianschmitz ianschmitz

Labels
CLA Signed tag: underlying tools
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@andriijas @ianschmitz @iansu @facebook-github-bot